This repository has been archived by the owner on May 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
[WEAV-65] ✨ 회원가입 토큰 발급 로직 및 카카오 IdToken resolve 로직 구현 #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
waterfogSW
commented
Jan 27, 2024
@@ -1,9 +1,10 @@ | |||
package com.studentcenter.weave.application.service | |||
package com.studentcenter.weave.application.service.util |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Service레이어 패키지를 application, domain, util 3가지로 나누었어요.
.
├── application
│ └── UserSocialLoginApplicationService.kt
├── domain
│ ├── UserAuthInfoDomainService.kt
│ ├── UserDomainService.kt
│ └── impl
│ ├── UserAuthInfoDomainServiceImpl.kt
│ └── UserDomainServiceImpl.kt
└── util
├── UserTokenService.kt
└── impl
├── UserTokenServiceImpl.kt
└── strategy
application 에는 usecase의 구현체인 애플리케이션 서비스
domain 에는 도메인 서비스,
util 에는도메인도, 애플리케이션 서비스도 아닌 협력 서비스로 분류했어요
domain이랑 util은 따로 인터페이스가 존재하지 않아서 인터페이스를 패키지 안에 정의해놓고 내부에 impl패키지 만들어서 구현체 만들어 두었어요
dojinyou
reviewed
Jan 27, 2024
...rc/main/kotlin/com/studentcenter/weave/application/service/util/impl/UserTokenServiceImpl.kt
Outdated
Show resolved
Hide resolved
...p/src/main/kotlin/com/studentcenter/weave/bootstrap/adapter/controller/AuthRestController.kt
Outdated
Show resolved
Hide resolved
infrastructure/persistence/src/main/resources/db/migration/V1__init.sql
Outdated
Show resolved
Hide resolved
waterfogSW
changed the title
[WEAV-65] 회원가입 토큰 발급 로직 및 카카오 IdToken resolve 로직 구현
[WEAV-65] ✨ 회원가입 토큰 발급 로직 및 카카오 IdToken resolve 로직 구현
Jan 27, 2024
dojinyou
reviewed
Jan 28, 2024
infrastructure/persistence/src/main/resources/db/migration/V1__init_user_auth_info.sql
Show resolved
Hide resolved
bootstrap/http/src/main/kotlin/com/studentcenter/weave/bootstrap/WeaveHttpApplication.kt
Outdated
Show resolved
Hide resolved
...dentcenter/weave/application/service/util/impl/strategy/OpenIdTokenResolveStrategyFactory.kt
Show resolved
Hide resolved
...tudentcenter/weave/application/service/util/impl/strategy/KakaoOpenIdTokenResolveStrategy.kt
Outdated
Show resolved
Hide resolved
dojinyou
approved these changes
Jan 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
닉네임 전략은 마이너해서 일단 어프로부입니더
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 2 New issues |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 내용