Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix truthy for numeric values #52

Merged
merged 4 commits into from
May 18, 2019
Merged

Fix truthy for numeric values #52

merged 4 commits into from
May 18, 2019

Conversation

emazv72
Copy link
Contributor

@emazv72 emazv72 commented May 15, 2019

Literals for number 0 are considered falsy with with patch.

Could you please review and merge commits 943b187 and 8fef46d?

@codecov
Copy link

codecov bot commented May 16, 2019

Codecov Report

Merging #52 into master will increase coverage by 0.07%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #52      +/-   ##
=========================================
+ Coverage   99.83%   99.9%   +0.07%     
=========================================
  Files          73      57      -16     
  Lines        3054    2204     -850     
=========================================
- Hits         3049    2202     -847     
+ Misses          5       2       -3
Impacted Files Coverage Δ
src/Stubble.Core/Contexts/Context.cs 100% <100%> (ø) ⬆️
...le.Compilation/Settings/CompilerSettingsBuilder.cs
...n/Renderers/TokenRenderers/SectionTokenRenderer.cs
...ubble.Compilation/Renderers/CompilationRenderer.cs
...c/Stubble.Compilation/Settings/CompilerSettings.cs
...n/Renderers/TokenRenderers/LiteralTokenRenderer.cs
.../Stubble.Compilation/Class/EnumerationConverter.cs
...n/Renderers/TokenRenderers/PartialTokenRenderer.cs
...ion/Renderers/PartialLambdaExpressionDefinition.cs
...rc/Stubble.Compilation/Settings/DefaultSettings.cs
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efc6b3d...8fef46d. Read the comment docs.

@Romanx Romanx merged commit 8654bf0 into StubbleOrg:master May 18, 2019
@Romanx
Copy link
Contributor

Romanx commented May 18, 2019

Thank you very much for you contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants