Feature/add routing manifest support #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juampi92
reviewed
Aug 3, 2022
publishable/config/api.php
Outdated
| | strategy for each Resource in every version. | ||
| */ | ||
|
|
||
| 'routing_manifest_path' => storage_path('api-resources/manifest.json'), |
There was a problem hiding this comment.
Could this be in the Laravel's framework cache? bootstrap/cache
juampi92
reviewed
Aug 3, 2022
src/APIResourceManager.php
Outdated
| */ | ||
| protected function parseClassname($classname, $forceLatest = false) | ||
| protected function parseClassname(string $classname, bool $forceLatest = false): string |
There was a problem hiding this comment.
The method that you're looking to modify is
public function resolve($classname)
The difference is that this method will simply try to resolve the class from the version name. This is how the manifest should be made
sunchayn
force-pushed
the
feature/add-routing-manifest-support
branch
from
819eaaf to
0e7adbd
Compare
sunchayn
force-pushed
the
feature/add-routing-manifest-support
branch
from
a98ead2 to
c2c84f5
Compare
juampi92
reviewed
Aug 3, 2022
src/Resolvers/Resolver.php
Outdated
| /** | ||
| * @return class-string<JsonResource|ResourceCollection> | ||
| */ | ||
| abstract protected function resolve(): ?string; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Boom,
first, the resolution strategy, if it is alright I can move to the commands part 👌