Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Synthetic Semantic Segmentation Benchmark #820

Merged
merged 36 commits into from
Nov 13, 2024
Merged

Conversation

czaloom
Copy link
Collaborator

@czaloom czaloom commented Nov 12, 2024

Changes

  • Added benchmark utilities to valor-lite.profiling
  • Added benchmarks in valor-lite.semantic_segmentation.benchmark
  • Added example notebook benchmarking.ipynb

@czaloom czaloom self-assigned this Nov 12, 2024
@czaloom czaloom marked this pull request as ready for review November 12, 2024 20:58
n_labels: int,
height: int,
width: int,
) -> Segmentation:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you should separate out the parts that generate synthetic data because those parts are useful outside of benchmarking. For example this could be used by something similar to the test_stability.py unit tests that detection and classification have. I have also used these to play around with the API and see what evaluations look like with different options. Very useful IMO and worth making it easy to do.

Not exactly sure where it should go, maybe in segmentation/synthetic.py or segmentation/test_data.py? Maybe right in segmentation/annotation.py itself? I'm open to other ideas.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Moved generate_segmentation to annotation.py!

@czaloom czaloom merged commit 300886e into main Nov 13, 2024
14 checks passed
@czaloom czaloom deleted the czaloom-synthetic-semseg-bench branch November 13, 2024 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants