Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Conditional types for futures and traits #416

Merged
merged 3 commits into from
Jan 19, 2023

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented Jan 5, 2023

Conditional Send is enabled by:

  • feature env-future-send (not applicable to wasm)
  • target_family != wasm reverted! will cause compile-time error if Send is enabled for wasm!

WASM futures should not be Send - rustwasm/wasm-bindgen#2833

TODO (before merging)

Check core-* builds:

@elpiel elpiel requested review from core1024 and tymmesyde January 5, 2023 09:08
@elpiel elpiel force-pushed the conidtional-send-trait branch 2 times, most recently from b3e9ca5 to 2935236 Compare January 13, 2023 11:19
@elpiel elpiel force-pushed the conidtional-send-trait branch from 2935236 to 27b664b Compare January 13, 2023 11:20
Signed-off-by: Lachezar Lechev <[email protected]>
@elpiel elpiel merged commit 27df1d0 into development Jan 19, 2023
@elpiel elpiel deleted the conidtional-send-trait branch January 19, 2023 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant