Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/StreamItemState subtitles size and offset #63

Merged
merged 3 commits into from
Nov 15, 2024
Merged

Feat/StreamItemState subtitles size and offset #63

merged 3 commits into from
Nov 15, 2024

Conversation

tymmesyde
Copy link
Member

@tymmesyde tymmesyde commented Nov 14, 2024 •
edited
Loading

1.3.1 not sure about how the versioning works for this repo

@tymmesyde tymmesyde requested review from elpiel and TheBeastLT and removed request for elpiel November 14, 2024 10:42
@elpiel elpiel changed the title Update core Feat/StreamItemState subtitles size and offset Nov 15, 2024
@elpiel elpiel mentioned this pull request Nov 15, 2024
Closed
1 task
elpiel
elpiel approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@elpiel elpiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Versioning is correct.
It;s not a breaking change so 1.3.1 is the version to use IMO.

@elpiel elpiel merged commit e80b435 into master Nov 15, 2024
1 check passed
@tymmesyde tymmesyde deleted the chore/update-core branch November 15, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elpiel elpiel elpiel approved these changes

@TheBeastLT TheBeastLT Awaiting requested review from TheBeastLT

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tymmesyde @elpiel