Feat: Improve imports and exports #48

elpiel · 2024-08-02T10:48:36Z

Adds stremio-core-protobuf
stremio-core-android - workspace setup, use protobuf crate and improve imports

TODOs:

check android protobuf generation, build.gradle.kts was altered but not tested locally - succesfully updated some deps + ndk version and the release build that's working can be verified by this run: https://github.com/Stremio/stremio-core-kotlin/actions/runs/11516232184
Revert core/core-web rev. once the improvements are merged upstream
De-duplication of MetaItems 118e0a2

…feature Signed-off-by: Lachezar Lechev <[email protected]>

…e-export in stremio-core-android Signed-off-by: Lachezar Lechev <[email protected]>

Signed-off-by: Lachezar Lechev <[email protected]>

…mio_core_android module Signed-off-by: Lachezar Lechev <[email protected]>

…ncies - use workspace deps. in stremio-core-protobuf Signed-off-by: Lachezar Lechev <[email protected]>

…tobuf files location Signed-off-by: Lachezar Lechev <[email protected]>

…piler Signed-off-by: Lachezar Lechev <[email protected]>

… fields from stremio-core-android Signed-off-by: Lachezar Lechev <[email protected]>

Signed-off-by: Lachezar Lechev <[email protected]>

…t's missing Signed-off-by: Lachezar Lechev <[email protected]>

Signed-off-by: Lachezar Lechev <[email protected]>

…with `kotlin` feature Signed-off-by: Lachezar Lechev <[email protected]>

… for the Model Field Signed-off-by: Lachezar Lechev <[email protected]>

Signed-off-by: Lachezar Lechev <[email protected]>

…endabot.yml for outdated deps. Signed-off-by: Lachezar Lechev <[email protected]>

Signed-off-by: Lachezar Lechev <[email protected]>

src/commonMain/rust/model/model.rs

stremio-core-protobuf/proto/stremio/core/types/manifest.proto

stremio-core-protobuf/src/bridge/event.rs

stremio-core-protobuf/src/bridge/loadable.rs

stremio-core-protobuf/src/bridge/resource_loadable.rs

stremio-core-protobuf/src/model/fields/catalogs_with_extra.rs

stremio-core-protobuf/src/bridge/action.rs

…ls with https:// Signed-off-by: Lachezar Lechev <[email protected]>

Signed-off-by: Lachezar Lechev <[email protected]>

stremio-core-protobuf/src/model/fields/addon_detail.rs

…AddonDescriptor

…and CatalogWithFiltersAll Signed-off-by: Lachezar Lechev <[email protected]>

Signed-off-by: Lachezar Lechev <[email protected]>

…emove it completely because of failing release build Signed-off-by: Lachezar Lechev <[email protected]>

Signed-off-by: Lachezar Lechev <[email protected]>

…setup Signed-off-by: Lachezar Lechev <[email protected]>

Signed-off-by: Lachezar Lechev <[email protected]>

elpiel and others added 30 commits August 1, 2024 17:56

chore(stremio-core-android): update time dep. and introduce kotlin …

c37f31b

…feature Signed-off-by: Lachezar Lechev <[email protected]>

feat(stremio-core-protobuf): move proto files and codegen there and r…

51c604a

…e-export in stremio-core-android Signed-off-by: Lachezar Lechev <[email protected]>

chore: add workspace deps for stremio-* crates

ba59b4b

Signed-off-by: Lachezar Lechev <[email protected]>

chore: rustfmt & clippy fixes + suppress missing safety docs for stre…

8d8a601

…mio_core_android module Signed-off-by: Lachezar Lechev <[email protected]>

chore(Cargo.toml): add prost and relative crates to workspace depende…

7264ed9

…ncies - use workspace deps. in stremio-core-protobuf Signed-off-by: Lachezar Lechev <[email protected]>

fix(stremio-core-protobuf): build.rs - use CARGO_MANIFEST_DIR for pro…

641a7da

…tobuf files location Signed-off-by: Lachezar Lechev <[email protected]>

fix: proto - Descriptor renamed to Descriptor__ because of protoc com…

40ed286

…piler Signed-off-by: Lachezar Lechev <[email protected]>

feat(stremio-core-protobuf): move and generalize the bridge and model…

b91e04e

… fields from stremio-core-android Signed-off-by: Lachezar Lechev <[email protected]>

chore: bridge- move ToProtobuf and FromProtobuf traits

757f260

Signed-off-by: Lachezar Lechev <[email protected]>

chore(fetch): Refactor to use async/await and remove either dep.

daff13a

Signed-off-by: Lachezar Lechev <[email protected]>

feat(protobuf): add stremio-core-web dep. for mode (de)serialization

45c462f

Signed-off-by: Lachezar Lechev <[email protected]>

feat(AndroidModelField): Impl From / Into Field

409a419

Signed-off-by: Lachezar Lechev <[email protected]>

chore: Update stremio-core & stremio-core-web rev.

a711963

Signed-off-by: Lachezar Lechev <[email protected]>

chore: rustfmt & clippy

bc5fda3

Signed-off-by: Lachezar Lechev <[email protected]>

fix(stremio-core-protobuf): build script creates protobuf folder if i…

34bab4c

…t's missing Signed-off-by: Lachezar Lechev <[email protected]>

fix(ci): build - add protoc setup because of stremio-core-csharp

4d7d4b7

Signed-off-by: Lachezar Lechev <[email protected]>

chore(Cargo): add workspace deps for the fetch impl

260c524

Signed-off-by: Lachezar Lechev <[email protected]>

chore(android): AndroidModel should be enabled only by the env. impl …

8068ee7

…with `kotlin` feature Signed-off-by: Lachezar Lechev <[email protected]>

chore(stremio-core-protobuf): RuntimeEvent - remove the need of Clone…

a57079a

… for the Model Field Signed-off-by: Lachezar Lechev <[email protected]>

fix: clippy warnings and cleanup code for bridge action

924ac1a

Signed-off-by: Lachezar Lechev <[email protected]>

chore(stremio-core-android): Use protobuf crate

b047db3

Signed-off-by: Lachezar Lechev <[email protected]>

ci: improve build by setting concurrency and protoc version + add dep…

87ed5f3

…endabot.yml for outdated deps. Signed-off-by: Lachezar Lechev <[email protected]>

feat(protobuf): field - add missing fields

cf337c5

Signed-off-by: Lachezar Lechev <[email protected]>

fix: add missing model fields for android

0b1f3cc

Signed-off-by: Lachezar Lechev <[email protected]>

feat(protobuf): add CatalogWithFiltersAll action for load in Board

f045bd5

Signed-off-by: Lachezar Lechev <[email protected]>

feat: Discovery (CatalogsWithExtraAll) & Search (CatalogsWithExtra)

8636383

Signed-off-by: Lachezar Lechev <[email protected]>

chore: use once_cell instead of lazy_static

aa87467

Signed-off-by: Lachezar Lechev <[email protected]>

chore: bump core rev

946586e

Signed-off-by: Lachezar Lechev <[email protected]>

fix: import

31bfd9b

Signed-off-by: Lachezar Lechev <[email protected]>

chore: use stremio-core development branch and comment stremio-core-web

9758f3b

Signed-off-by: Lachezar Lechev <[email protected]>

elpiel added 3 commits October 8, 2024 16:02

fix: clippy

27d72c3

chore: tweak workspace dependencies

b76df1b

Signed-off-by: Lachezar Lechev <[email protected]>

feat(ci): build & release - optimize workflows

710cc4d

Signed-off-by: Lachezar Lechev <[email protected]>

elpiel mentioned this pull request Oct 16, 2024

chore: update deps and change edition to 2021 #36

Closed

6 tasks

elpiel marked this pull request as ready for review October 16, 2024 08:32

TheBeastLT reviewed Oct 17, 2024

View reviewed changes

feat(stremio-core-protobuf): addon-detail replace addon stremio:// ur…

72bbd76

…ls with https:// Signed-off-by: Lachezar Lechev <[email protected]>

elpiel force-pushed the feat/improve-imports-and-exports branch from 0d6562e to 72bbd76 Compare October 17, 2024 16:10

chore: address PR review comments

3586458

Signed-off-by: Lachezar Lechev <[email protected]>

TheBeastLT reviewed Oct 18, 2024

View reviewed changes

stremio-core-protobuf/src/model/fields/addon_detail.rs Show resolved Hide resolved

tymmesyde and others added 5 commits October 18, 2024 12:51

feat: add library_with_filters actions

3022b9d

fix(stremio-core-protobuf): maniifest.proto - rename Descriptor__ to …

318beb6

…AddonDescriptor

chore: clean up commented out code

5520610

Merge branch 'master' into feat/improve-imports-and-exports

e4ab8d5

fix(stremio-core-protobuf): ActionLoad - remove CatalogsWithExtraAll …

e0c570b

…and CatalogWithFiltersAll Signed-off-by: Lachezar Lechev <[email protected]>

elpiel force-pushed the feat/improve-imports-and-exports branch 2 times, most recently from bce5084 to 1e808f1 Compare October 21, 2024 14:50

fix(stremio-core-protobuf): should include staticlib and dylib

2a363bc

Signed-off-by: Lachezar Lechev <[email protected]>

elpiel force-pushed the feat/improve-imports-and-exports branch from 1e808f1 to 2a363bc Compare October 21, 2024 16:26

elpiel added 3 commits October 24, 2024 08:43

Merge branch 'master' into feat/improve-imports-and-exports

ab430f2

fix(stremio-core-android): Cargo - crate-type didn't work before so r…

ebf72b7

…emove it completely because of failing release build Signed-off-by: Lachezar Lechev <[email protected]>

fix: build.gradle.kts - source dir for .proto files

711ba89

Signed-off-by: Lachezar Lechev <[email protected]>

elpiel force-pushed the feat/improve-imports-and-exports branch from 4050570 to 711ba89 Compare October 24, 2024 11:08

TheBeastLT and others added 5 commits October 24, 2024 14:42

fix(stremio-core-protobuf):source dir syntax

5eda198

fix: bump android ndk

f6d36bc

fix: configure ranlib for each individual rust target

28d4888

docs: Readme, release & config - explain NDK version and ranlib path …

8fc051b

…setup Signed-off-by: Lachezar Lechev <[email protected]>

fix: readme

9baf392

Signed-off-by: Lachezar Lechev <[email protected]>

elpiel merged commit 7ca0ae9 into master Oct 25, 2024
1 check passed

TheBeastLT deleted the feat/improve-imports-and-exports branch October 25, 2024 10:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat: Improve imports and exports #48

Feat: Improve imports and exports #48

elpiel commented Aug 2, 2024 •

edited

Loading

Feat: Improve imports and exports #48

Feat: Improve imports and exports #48

Conversation

elpiel commented Aug 2, 2024 • edited Loading

TODOs:

elpiel commented Aug 2, 2024 •

edited

Loading