Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update core and most of the models & fields #42

Merged
merged 8 commits into from
Nov 2, 2023

Conversation

elpiel
Copy link
Member

@elpiel elpiel commented Oct 31, 2023

No description provided.

@elpiel elpiel requested review from TheBeastLT and sleeyax October 31, 2023 07:15
@elpiel elpiel force-pushed the chore/update-core branch from da56f34 to bb12cf8 Compare October 31, 2023 07:24

impl ToProtobuf<models::ContinueWatchingItem, (Option<&StreamsItem>, Option<&Url>, &Settings)> for Item {
fn to_protobuf(&self, args: &(Option<&StreamsItem>, Option<&Url>, &Settings)) -> models::ContinueWatchingItem {
// Option<&StreamsItem>,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented code?

@@ -6,14 +6,16 @@ option java_package = "com.stremio.core.runtime.msg";

import "google/protobuf/empty.proto";

import "stremio/core/types/video.proto";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need for new line after each import

@elpiel elpiel merged commit 0108801 into master Nov 2, 2023
@elpiel elpiel deleted the chore/update-core branch November 2, 2023 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants