Skip to content

Commit

Permalink
Merge pull request Azure#103 from StrawnSC/fix-gh-cred-caching
Browse files Browse the repository at this point in the history
`az containerapp up` -- only encrypt cached GitHub creds on windows
  • Loading branch information
StrawnSC authored May 12, 2022
2 parents 914a32b + 3b47ea4 commit 7bacfac
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion src/containerapp/azext_containerapp/_github_oauth.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
# pylint: disable=consider-using-f-string

import os
import sys
from datetime import datetime

from knack.log import get_logger
Expand Down Expand Up @@ -33,7 +34,9 @@

def _get_github_token_secret_store(cmd):
location = os.path.join(cmd.cli_ctx.config.config_dir, "github_token_cache")
file_persistence = build_persistence(location, encrypt=True)
# TODO use core CLI util to take care of this once it's merged and released
encrypt = sys.platform.startswith('win32') # encryption not supported on non-windows platforms
file_persistence = build_persistence(location, encrypt)
return SecretStore(file_persistence)


Expand Down

0 comments on commit 7bacfac

Please sign in to comment.