Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Rework Registry #686

Merged
merged 7 commits into from
Feb 4, 2025
Merged

chore: Rework Registry #686

merged 7 commits into from
Feb 4, 2025

Conversation

Stranger6667
Copy link
Owner

No description provided.

@Stranger6667 Stranger6667 marked this pull request as draft February 1, 2025 11:28
Copy link

codspeed-hq bot commented Feb 3, 2025

CodSpeed Performance Report

Merging #686 will improve performances by ×5.8

Comparing dd/registry (6d96917) with master (86033cf)

Summary

⚡ 15 improvements
✅ 30 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
try_new[draft 2019-09] 76.2 µs 52.2 µs +45.94%
try_new[draft 2020-12] 80.5 µs 55.2 µs +45.94%
try_new[draft 4] 65 µs 48.5 µs +33.99%
try_new[draft 6] 71.7 µs 51.1 µs +40.34%
try_new[draft 7] 81.5 µs 54.7 µs +49.13%
try_with_resource[CITM] 214.4 µs 72.4 µs ×3
try_with_resource[Fast] 65.3 µs 39.6 µs +64.63%
try_with_resource[GeoJSON] 761.7 µs 132.1 µs ×5.8
try_with_resource[Open API] 1,306.9 µs 436.8 µs ×3
try_with_resource[Swagger] 1,288 µs 432.6 µs ×3
build[CITM] 570.1 µs 417.8 µs +36.46%
build[Fast] 224 µs 188.3 µs +18.96%
build[GeoJSON] 1,557.8 µs 906.4 µs +71.88%
build[Open API] 8.2 ms 7.5 ms +10.37%
build[Swagger] 6.9 ms 6.1 ms +12.42%

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 99.09707% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.70%. Comparing base (86033cf) to head (6d96917).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
crates/jsonschema-referencing/src/registry.rs 97.53% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #686      +/-   ##
==========================================
+ Coverage   85.42%   85.70%   +0.27%     
==========================================
  Files          90       92       +2     
  Lines       14137    14408     +271     
==========================================
+ Hits        12077    12348     +271     
  Misses       2060     2060              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Stranger6667 Stranger6667 force-pushed the dd/registry branch 3 times, most recently from 2edbcd5 to fb2cd50 Compare February 4, 2025 10:17
Signed-off-by: Dmitry Dygalo <[email protected]>
Signed-off-by: Dmitry Dygalo <[email protected]>
Signed-off-by: Dmitry Dygalo <[email protected]>
Signed-off-by: Dmitry Dygalo <[email protected]>
Signed-off-by: Dmitry Dygalo <[email protected]>
Signed-off-by: Dmitry Dygalo <[email protected]>
Signed-off-by: Dmitry Dygalo <[email protected]>
@Stranger6667 Stranger6667 marked this pull request as ready for review February 4, 2025 20:59
@Stranger6667 Stranger6667 merged commit 638d2ed into master Feb 4, 2025
37 of 39 checks passed
@Stranger6667 Stranger6667 deleted the dd/registry branch February 4, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant