Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of unintended absolute plots of real and imaginary parts in crossspectrum #747

Conversation

pupperemeritus
Copy link
Contributor

Removed erroneous absolution of crossspectrum values in plot function.

@pupperemeritus pupperemeritus force-pushed the Crossspectrum_plot_absolute_removal branch from 1357ee8 to 811e463 Compare August 21, 2023 07:58
@pupperemeritus pupperemeritus force-pushed the Crossspectrum_plot_absolute_removal branch from 811e463 to 8fc8c28 Compare August 21, 2023 08:33
@codecov
Copy link

codecov bot commented Aug 21, 2023

Codecov Report

Merging #747 (8fc8c28) into main (f3d75e8) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #747   +/-   ##
=======================================
  Coverage   97.13%   97.13%           
=======================================
  Files          42       42           
  Lines        7919     7919           
=======================================
  Hits         7692     7692           
  Misses        227      227           
Files Changed Coverage Δ
stingray/crossspectrum.py 98.21% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@matteobachetti matteobachetti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is how it should work. Thanks @pupperemeritus

@matteobachetti matteobachetti added this pull request to the merge queue Aug 21, 2023
Merged via the queue into StingraySoftware:main with commit 38ca23b Aug 21, 2023
@pupperemeritus pupperemeritus deleted the Crossspectrum_plot_absolute_removal branch February 12, 2024 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants