Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

static_if_impl has to be replaced with if constexpr #204

Closed
eao197 opened this issue Dec 7, 2023 · 0 comments
Closed

static_if_impl has to be replaced with if constexpr #204

eao197 opened this issue Dec 7, 2023 · 0 comments
Assignees
@eao197
Milestone
0.7.1

Comments

@eao197
Copy link
Member

eao197 commented Dec 7, 2023

There is a workaround for absence of if constexpr in C++14 in the form of static_if_impl. This workaround is now used here:

restinio/dev/restinio/impl/response_coordinator.hpp

Line 98 in 1f95dbc

static_if_else< noexcept(m_write_groups.erase(m_write_groups.begin())) >(

The static_if_impl has to be replaced with if constexpr because RESTinio is now C++17 library.
@eao197 eao197 added this to the 0.7.1 milestone Dec 7, 2023
@eao197 eao197 self-assigned this Dec 7, 2023
eao197 added a commit that referenced this issue Dec 13, 2023
@eao197
A fix for #204.
c2913e9
@eao197 eao197 closed this as completed Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eao197 eao197

Labels
None yet
Projects
None yet
Milestone
0.7.1
Development

No branches or pull requests
1 participant
@eao197