Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using RESTINIO_FIND_DEPS=ON and RESTINIO_FMT_HEADER_ONLY=OFF cmake fails on configure step #159

Closed
jonboh opened this issue May 19, 2022 · 2 comments

Comments

@jonboh
Copy link

jonboh commented May 19, 2022

restinio target is defined as an INTERFACE library in https://github.com/Stiffstream/restinio/blob/v.0.6.14/dev/restinio/CMakeLists.txt#L9
however when RESTINIO_FIND_DEPS=ON and RESTINIO_FMT_HEADER_ONLY=OFF fmt::fmt is linked with PUBLIC which is not allowed https://github.com/Stiffstream/restinio/blob/v.0.6.14/dev/restinio/CMakeLists.txt#L56

I get the following error:

[build] CMake Error at C:/Dev/trunk/src_thirdparty/build/restinio/dev/restinio/CMakeLists.txt:56 (TARGET_LINK_LIBRARIES):
[build]   INTERFACE library can only be used with the INTERFACE keyword of
[build]   target_link_libraries
[build] 
[build] 
[build] -- Configuring incomplete, errors occurred!
eao197 added a commit that referenced this issue May 20, 2022
eao197 added a commit that referenced this issue May 20, 2022
@eao197
Copy link
Member

eao197 commented May 20, 2022

Hi, thanks for reporting.

The fix is in issue-159 branch.

I hope I can merge it into the master at the beginning of the next week. But I don't know when I can release a new version of RESTinio as tag.

@eao197
Copy link
Member

eao197 commented May 26, 2022

Hi!

The fix is a part of 0.6.15 release now.

@eao197 eao197 closed this as completed Jul 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants