Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build by removing linker flags #295

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

james-ward
Copy link
Contributor

Closes #294

Copy link
Owner

@SteveMacenski SteveMacenski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting on @Timple but LGTM.

@Timple
Copy link
Contributor

Timple commented Jun 24, 2024

Well, this check should not have false positives. But you are right, there is an issue upstream which causes this: ros2/rosidl_python#213

I would put these lines below the message generation, that also works. With a comment why this is at that location referencing the upstream issue.

But I'm also not against removing it as it's just an extra check preventing runtime linking issues.

@SteveMacenski
Copy link
Owner

That seems reasonable to me. @james-ward can you move it below the messages?

@SteveMacenski SteveMacenski merged commit dfbbefb into SteveMacenski:ros2 Jun 24, 2024
@Rayman
Copy link
Contributor

Rayman commented Jun 25, 2024

@james-ward you can also move the linker flags after the messages are generated. Then we still get warnings from our own code, but not from the messages

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linker options causing build failure
4 participants