Fixing behavior when module ignores necessity of topic options update…

… for existing topics if topic provided with default values for partitions and/or replica_factor.
StephenSorriaux · Jul 23, 2024 · 9b31e10 · 9b31e10
1 parent edf73b0
commit 9b31e10
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/module_utils/kafka_manager.py b/module_utils/kafka_manager.py
@@ -1499,16 +1499,17 @@ def get_topics_to_update(self, topics):
                         topic['name']
                     )
                 )
-        topics = [
-            topic for topic in topics if (
-                topic['partitions'] > 0 and topic['replica_factor'] > 0)
-        ]
         topics_changed.update(
             self.is_topics_configuration_need_update({
                 topic['name']: topic['options'].items()
                 for topic in topics
             })
         )
+
+        topics = [
+            topic for topic in topics if (
+                topic['partitions'] > 0 and topic['replica_factor'] > 0)
+        ]
         topics_changed.update(
             self.is_topics_replication_need_update({
                 topic['name']: {
@@ -1546,10 +1547,6 @@ def ensure_topics(self, topics):
                     )
                 )
 
-        topics = [
-            topic for topic in topics if (
-                topic['partitions'] > 0 and topic['replica_factor'] > 0)
-        ]
 
         topics_config_need_update = self.is_topics_configuration_need_update({
             topic['name']: topic['options'].items()
@@ -1563,6 +1560,10 @@ def ensure_topics(self, topics):
             })
             topics_changed.update(topics_config_need_update)
 
+        topics = [
+            topic for topic in topics if (
+                topic['partitions'] > 0 and topic['replica_factor'] > 0)
+        ]
         topics_replication_need_update = \
             self.is_topics_replication_need_update({
                 topic['name']: {