Shut Up PollConnector! #62
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Are you happy now PollConnector? Hmm? Now that I have given you all of the variables you could ever possibly want? Are there any other "undefined" values you want fake placeholders for? HMMMM? NO? GOOD! also put klipper macros in their own folder.
|
Very Good. Now is better. |
|
its month ago and i still not see whats wrong with poll collecting as is. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ok, this is a bigger one. I've been just trying to clean up error messages more than anything, and this seems to have done it. The majority for the warnings come through when the printer is off and klipper is waiting to connect. All status requests are forwarded to type 0 instead of the types that have these values in the response, which makes the connector very unhappy because it was expecting a different response. Both status 2 and 3 were expected to report a standby temp for the bed heater, which I thought was odd, but not a big deal I guess. Small usability change: I moved all of the klipper macros to their own folder, and only render them when you are in that folder. Since those files don't actually exist, this keeps them separate from actual dwc macros. I have klipper macros set up for changing tools in klippers config file, and now I can have dwc macros for things that the firmware doesn't need to worry about when printing for example like turning lights on/off.
Non of these changes are strictly "necessary" but they do quite down the warnings. I've been testing, and so far nothing has broken as a result.
Are you happy now PollConnector? Hmm? Now that I have given you all of the variables you could ever possibly want? Are there any other "undefined" values you want fake placeholders for? HMMMM? NO? GOOD!
also put klipper macros in their own folder.