Skip to content

Commit

Permalink
checking type consistency works
Browse files Browse the repository at this point in the history
  • Loading branch information
@anicusan
anicusan committed Nov 23, 2024
1 parent 88b4248 commit 22e1a03
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion test/runtests.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -773,7 +773,10 @@ end
BVH(bvs, BBox{Float64}, UInt32, 0.0)
BVH(bvs, BBox{Float64}, UInt32, 0.5)
BVH(bvs, BBox{Float64}, UInt32, 1.0)
BVH(bvs, BBox{Float64}, UInt32, 3, bvh)
BVH(bvs, BSphere{Float64}, UInt32, 3, bvh)

# Type mismatch between cache (BSphere) and nodes (BBox)
@test_throws ArgumentError BVH(bvs, BBox{Float64}, UInt32, 1, bvh)

traverse(bvh, 3)
traverse(bvh, 3, traversal)
Expand Down

4 comments on commit 22e1a03

@anicusan
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/120058

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.5.0 -m "<description of version>" 22e1a035640e9183f31e2b31b7e9936a06068294
git push origin v0.5.0

@anicusan
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

Release notes:

  • GPU acceleration using AcceleratedKernels.jl
  • Ray-tracing!

Internal

  • Coherent index types used in kernels
  • Exposing cache from BVH builder for memory reuse

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request updated: JuliaRegistries/General/120058

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.5.0 -m "<description of version>" 22e1a035640e9183f31e2b31b7e9936a06068294
git push origin v0.5.0

Please sign in to comment.