-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resources for building Windows Server 2022 with Docker #316
Add resources for building Windows Server 2022 with Docker #316
Conversation
This is a copy of the corresponding resources from Windows Server Core 2019. Some adjustments have been made to reflect the different .iso image.
It needs a patch to the sister repository to build box images for Windows Server 2022 including Docker. Reference: StefanScherer/packer-windows#316
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @amotl !
Thank you very much for your contribution. This is awesome!
I have only one minor nit. The template itself looks good!
@@ -32,6 +32,7 @@ The following Windows versions are known to work (built with VMware Fusion Pro | |||
* Windows Server 2022 Desktop -> Vagrant Cloud box [StefanScherer/windows_2022](https://app.vagrantup.com/StefanScherer/boxes/windows_2022) | |||
* Windows Server 2019 Desktop -> Vagrant Cloud box [StefanScherer/windows_2019](https://app.vagrantup.com/StefanScherer/boxes/windows_2019) | |||
* Windows Server Core | |||
* Windows Server 2022 without and with Docker -> Vagrant Cloud box [StefanScherer/windows_2022_docker](https://app.vagrantup.com/StefanScherer/boxes/windows_2022_docker) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest to skip the link to a Vagrant Cloud box. My pipeline to build and upload such boxes is broken and I hadn't the time to investigate and fix it.
* Windows Server 2022 without and with Docker -> Vagrant Cloud box [StefanScherer/windows_2022_docker](https://app.vagrantup.com/StefanScherer/boxes/windows_2022_docker) | |
* Windows Server 2022 without and with Docker |
Let's merge it, maybe I can find some time to upload a first box manually. |
Dear Stefan, wow, that was quick. Special kudos for building and uploading the new box image right away. We added a more verbose response about what we are aiming at to StefanScherer/windows-docker-machine#85 (comment) and will let you know what will come out of it. Thank you very much and have a good weekend. With kind regards, |
Dear Stefan and all contributors,
thank you very much for maintaing this excellent repository. We are aiming to modernize the sweetness of what is already available for the Windows Server 2016 and 2019 releases and add corresponding support for Windows Server 2022.
While you added general support for Windows 2022 with #301 already, corresponding resources for the Docker-flavoured builds for
windows_2022_docker
have still been missing. Usingwindows_2019_docker
as a blueprint and by mixing in the updates fromwindows_2022
, this patch was easy to make. We hope you like it.However, you would need to build and publish the corresponding artefacts to Vagrant Cloud after integrating the patch. Therefore, we are humbly asking for your support.
Keep up the spirit and with kind regards,
Andreas.