Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Solaris ENOATTR build failure #18

Closed
jperkin opened this issue Jun 22, 2018 · 1 comment
Closed

Solaris ENOATTR build failure #18

jperkin opened this issue Jun 22, 2018 · 1 comment

Comments

@jperkin
Copy link

jperkin commented Jun 22, 2018

The commit 0d637ae switches to ENOATTR in preference to ENODATA, however this causes the build to fail on Solaris which does not provide ENOATTR. I assume the same will be true of all unsupported platforms.

error[E0432]: unresolved import `libc::ENOATTR`
 --> vendor/xattr/src/util.rs:8:20
  |
8 | use libc::{ERANGE, ENOATTR, ssize_t};
  |                    ^^^^^^^ no `ENOATTR` in the root. Did you mean to use `ENOTTY`?

Is the correct fix here to work around it in the module, or add a dummy libc::ENOATTR alias for libc::NODATA to rust?

Stebalien added a commit that referenced this issue Jun 22, 2018
@Stebalien
Copy link
Owner

Fixed in #19. Could you test it?

FYI, solaris technically supports extended attributes. Would you like to try adding full support? #19 just makes it compile, it doesn't actually add support.

Here's some code that might get you started:

https://github.com/xattr/xattr/blob/85420e91be287ac9bb5ef2f1ae5e1b34131cc0b1/xattr/lib_build.py#L279-L456

(no pressure 😄)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants