Fix build failure due to Codecov #513
Conversation
OpenCover requires Windows PDBs. In addition, the -oldStyle switch must be passed for .NET Standard projects.
SteamKit2/SteamKit2/SteamKit2.csproj
Outdated
| @@ -16,6 +16,11 @@ | |||
| <PropertyGroup> | |||
| <DocumentationFile>bin\$(Configuration)\$(TargetFramework)\SteamKit2.xml</DocumentationFile> | |||
| </PropertyGroup> | |||
|
|
|||
| <PropertyGroup Condition="'$(Configuration)|$(Platform)'=='Debug|AnyCPU'"> | |||
There was a problem hiding this comment.
Perhaps this should just be Condition="'$(Configuration)'=='Debug'". I know Visual Studio generates it in this form, but platform is unneccesary here.
|
Do you know why the Python version fails and succeeds simultaneously? I'd rather switch to the .NET version regardless - keeps the tooling etc. consistent. |
Codecov Report
@@ Coverage Diff @@
## master #513 +/- ##
=======================================
Coverage ? 22%
=======================================
Files ? 85
Lines ? 8634
Branches ? 710
=======================================
Hits ? 1900
Misses ? 6609
Partials ? 125Continue to review full report at Codecov.
|
|
Not sure why the Python version fails the way it does. It's really odd. |
|
Thanks! |
Fixes #512
The Python version of Codecov is causing the build to fail despite succeeding. It's replaced with the .NET version which doesn't have this issue.
This also fixes support for generating code coverage results. OpenCover cannot generate code coverage results for portable PDBs (OpenCover/opencover#610) so the Debug build now produces Windows PDBs. In addition, OpenCover requires
mscorlib.dllto be namedmscorlibbut that's not the case for .NET Standard (OpenCover/opencover#595). The-oldStyleswitch is used to work around this.