Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move webui protos to SteamKit2.WebUI.Internal #1342

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Move webui protos to SteamKit2.WebUI.Internal #1342

merged 1 commit into from
Mar 19, 2024

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Mar 18, 2024

Also added a few new ones. They are useful to have, but the way webui dumping works, I'm not confident in it long term.

I did not generate webui/common, because that ends up being a 1mb file, and we can reuse Steam common protos.

Dumper code lives here: https://github.com/SteamDatabase/SteamTracking/blob/master/dump_javascript_protobufs.mjs

@JustArchi
Copy link
Contributor

Could you consider adding https://github.com/SteamDatabase/Protobufs/blob/master/webui/service_familygroups.proto too? Would help me over in ASF, thank you in advance 🙏

@xPaw
Copy link
Member Author

xPaw commented Mar 19, 2024

Family groups exist in Steam protos, so generated here: 530f8e4

@JustArchi
Copy link
Contributor

Great, thanks a lot! 👍

@ezhevita
Copy link
Contributor

Please consider adding service_loyaltyrewards.proto (used by ASF) and service_accountcart.proto with service_checkout.proto for generation

@xPaw
Copy link
Member Author

xPaw commented Mar 19, 2024

The annoying thing about cart and checkout protos is that they actually require webui/common, but the generator does not really support only generating the messages that are used. I don't want to bring 1mb of common protos in steamkit.

If the generator somehow could just copy stuff it needs from common, that would solve this issue.

@xPaw
Copy link
Member Author

xPaw commented Mar 19, 2024

After some discussion, as these protos are useful to have, and trying to solve common protos is a bit of a pain, i'm gonna include them.

This should be solved by fixing trimming instead: #1057

@xPaw xPaw merged commit 26145f9 into master Mar 19, 2024
15 checks passed
@xPaw xPaw deleted the webprotos branch March 19, 2024 11:21
@xPaw xPaw added this to the 3.0.0 milestone Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants