-
Notifications
You must be signed in to change notification settings - Fork 165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Request] Plugin.uninstall callback function #536
Labels
feature request
a request for a feature, no guarantee of addition
Comments
wheaney
added
the
feature request
a request for a feature, no guarantee of addition
label
Sep 6, 2023
wheaney
added a commit
to wheaney/decky-loader
that referenced
this issue
Oct 24, 2023
wheaney
added a commit
to wheaney/decky-loader
that referenced
this issue
Nov 1, 2023
wheaney
added a commit
to wheaney/decky-loader
that referenced
this issue
Nov 1, 2023
wheaney
added a commit
to wheaney/decky-loader
that referenced
this issue
Nov 1, 2023
@PartyWumpus This is showing up as assigned to me in the SDH Tracker. I've implemented and tested this myself, so at this point I'm just waiting for reviews/testing. Should it be assigned to someone else (or unassigned)? |
@wheaney we simply use assignment as a marker of who requested and or is working on a feature request etc. |
wheaney
added a commit
to wheaney/decky-loader
that referenced
this issue
Feb 26, 2024
JohnnyCrazy
pushed a commit
that referenced
this issue
Mar 13, 2024
* Add Plugin.uninstall callback support #536 * Remove empty deck.sh
AAGaming00
pushed a commit
that referenced
this issue
Apr 24, 2024
* Add Plugin.uninstall callback support #536 * Remove empty deck.sh
bricefriha
pushed a commit
to bricefriha/decky-loader
that referenced
this issue
Jun 3, 2024
* Add Plugin.uninstall callback support SteamDeckHomebrew#536 * Remove empty deck.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Please confirm
Feature Request Description
During uninstall, decky-loader calls stop() which triggers
_unload()
, but from my conversations in Discord, I can't rely on_unload()
to be 1:1 with uninstall (i.e. it may be triggered at other times in the plugin lifecycle).My plugin installs a systemd service when it's loaded, but since there's no reliable way to tap into decky's uninstall mechanism, a user uninstalling my plugin may be surprised to find that it's still operating behind the scenes.
This request is to add an
uninstall
function to the Plugin interface that is called afterstop()
and before deletion of the plugin directory.Further Description
No response
The text was updated successfully, but these errors were encountered: