-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve proxy management for data using COW #81
Open
pfernique
wants to merge
16
commits into
StatisKit:master
Choose a base branch
from
pfernique:feature_81
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has to be done for:
|
pfernique
changed the title
Improve proxy management for data using COW
WIP: Improve proxy management for data using COW
May 6, 2019
pfernique
changed the title
WIP: Improve proxy management for data using COW
Improve proxy management for data using COW
May 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some proxies are used to fasten data manipulation (e.g.,
WeightedData
) are error prone (segfaults) or induce non user-friendly manipulation (e.g.,ProxyError
thrown).From now, these proxies are constructed from a pointer to the decorated data and store this pointer.
Since this decorated data can be deleted, some tests are required to ensure that pointed data still exists.
Since most of these proxies are constructed from data that won't be modified, using the COW design pattern will as efficient and far more user-friendly.