Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused variables causing /phone-numbers blank screen error for Admins #2498

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

mau11
Copy link
Member

@mau11 mau11 commented Oct 21, 2024

Fixes # (issue)

Description

Removes no longer used variables that causes a blank screen error on the /phone-numbers page for Admins users (does not occur for Owners). Also pulled in a styling fix from PR #2457

before

before

after

after

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@mau11 mau11 mentioned this pull request Oct 21, 2024
7 tasks
Copy link
Collaborator

@engelhartrueben engelhartrueben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@engelhartrueben engelhartrueben merged commit 673c07b into stage-main-14.1.2 Oct 21, 2024
17 checks passed
@engelhartrueben engelhartrueben deleted the mz/clean-up branch October 21, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants