Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix UserInputError GraphQL errors #2492

Merged

Conversation

jeffm2001
Copy link
Collaborator

@jeffm2001 jeffm2001 commented Oct 15, 2024

Description

If you try to use the bulk reassign button in the admin message review screen, you get a GraphQL UserInputError because newTexterUserId is an int instead of the expected string.

CleanShot 2024-10-15 at 14 31 38

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@jeffm2001 jeffm2001 changed the title Fix error on bulk reassign Fix UserInputError GraphQL errors Oct 16, 2024
@jeffm2001
Copy link
Collaborator Author

Found some additional UserInputError issues on the Sweep Conversations page and on the Message Review page when filtering by error code

@mau11
Copy link
Member

mau11 commented Oct 21, 2024

thanks so much Jeff for fixing this! We've been seeing a lot of type errors since updating to Node 20.

Although this is working, I noticed this error in the logs: backend error TypeError: Cannot read properties of null (reading 'toString') coming from src/server/api/conversations.js:498, can you add a null check? Aside from that, looks great!

          assignmentId: assignmentId?.toString()

@jeffm2001
Copy link
Collaborator Author

Yep, makes sense!

@mau11 mau11 changed the base branch from main to stage-main-14.1.2 October 21, 2024 22:14
@mau11 mau11 merged commit ec0e69b into StateVoicesNational:stage-main-14.1.2 Oct 21, 2024
8 checks passed
@mau11 mau11 mentioned this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants