Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid error on opt-out #2491

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

jeffm2001
Copy link
Collaborator

Description

With the per-state opt-out message feature introduced in #2333, an error gets logged on each opt-out if you don't have the Smarty API configured. These error are harmless since it returns the default opt-out message anyway, but still, they can be avoided.

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@jeffm2001 jeffm2001 requested a review from crayolakat October 15, 2024 18:05
@engelhartrueben engelhartrueben added the S-on deck Status (ADMINS ONLY): PR label for those that will be added to the next stage label Oct 18, 2024
Copy link
Member

@mau11 mau11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jeff!

@mau11 mau11 changed the base branch from main to stage-main-14.1.2 October 18, 2024 18:36
@mau11 mau11 merged commit fd745e4 into StateVoicesNational:stage-main-14.1.2 Oct 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-on deck Status (ADMINS ONLY): PR label for those that will be added to the next stage
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants