Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Redis and readonly DB certificate issues #2488

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

jeffm2001
Copy link
Collaborator

@jeffm2001 jeffm2001 commented Oct 14, 2024

Description

After upgrading to v14, our connections to the Redis cache and the readonly follower database started failing with errors for self-signed certificates.

This PR updates the readonly database connection code to match the main database connection, and uses the correct configuration syntax for newer versions of node-redis.

Also fixes an unrelated error that occurs when redis is enabled that originated from the node upgrade.

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

Copy link
Member

@mau11 mau11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Jeff for catching these!

@mau11 mau11 changed the base branch from main to stage-main-14.1.2 October 18, 2024 18:39
@mau11 mau11 merged commit f22ce38 into StateVoicesNational:stage-main-14.1.2 Oct 18, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants