Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Campaign Number Picker #2479

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Campaign Number Picker #2479

wants to merge 2 commits into from

Conversation

jeffm2001
Copy link
Collaborator

@jeffm2001 jeffm2001 commented Oct 4, 2024 •
edited
Loading

Description

Adds a number picker service manager, which allows you to select specific numbers to use in the campaign configuration.

CleanShot 2024-10-04 at 15 13 49

This serves the same basic purpose as the former EXPERIMENTAL_CAMPAIGN_PHONE_NUMBERS feature did before it was removed in version 11.0. The current per-campaign-messageservices service manager can also serve a similar purpose, except it's specific to Twilio.

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jeffm2001