Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to enter 0 hours for instant reassignment #2474

Draft
wants to merge 2 commits into
base: stage-main-14.1.1
Choose a base branch
from
Draft

Allow users to enter 0 hours for instant reassignment #2474

wants to merge 2 commits into from

Conversation

mau11
Copy link
Member

@mau11 mau11 commented Oct 1, 2024

Fixes # (issue)

Description

Issue

This branch fixes the UX and adds support for a 0 hour response window

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@mau11 mau11 changed the base branch from main to stage-main-14.1.1 October 1, 2024 07:17
mau11
mau11 commented Oct 1, 2024
View reviewed changes
src/components/CampaignDynamicAssignmentForm.jsx
control={
<Switch
color="primary"
checked={useDynamicReplies || false}
Copy link
Member Author

@mau11 mau11 Oct 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

future - we need to add a linter to the repo to avoid these type of indentation updates

@engelhartrueben engelhartrueben marked this pull request as ready for review October 1, 2024 15:35
@mau11 mau11 requested a review from engelhartrueben October 1, 2024 16:22
@mau11 mau11 marked this pull request as draft October 1, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engelhartrueben engelhartrueben Awaiting requested review from engelhartrueben

Assignees
No one assigned
Labels
None yet
Projects
Spoke Release Schedule
Status: FEATURES
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mau11