-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archive Issue #2473
Merged
Merged
Archive Issue #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@mau11 linted + removed the unused import. Ready for review |
mau11
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Broken archives. The UI failed to show that a campaign was archived, even though it is on the backend/props.
Description
The fix for the buggy archives was in
src/component/AdminCampaignList.js:54-85
in therenderArchiveIcon
. Effectively, when the archive/unarchive button is pressed, we update the state to filter out the campaign that was just archived/unarchived.Additionally, this PR:
@testing-library/dom: ^10.4.0
,@testing-library/react: ^12.1.5
, and@testing-library/user-event: ^12.1.5
to replaceenzyme
for both this work and future work. This was necessary, as the conversion to function components broke Enzyme in a way that could not be fixed. Enzyme needs to be removed in order to upgrade React. Plus it's super unmaintained.Note
Only two of the tests were converted to React Testing Library. Depending, I may get around to removing enzyme entirely before the patch goes out.
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change, and any blockers that make your change a WIP
Checklist: