Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix getAsync + delAsync redis errors #2472

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

mau11
Copy link
Member

@mau11 mau11 commented Sep 30, 2024

Fixes # (issue)

Description

During the Node 20 update, redis was also updated and getAsync() + delAsync() functions were deprecated. In Spoke v14.1, we merged in older code that still contained these functions. This branch cleans them up and prevents errors like below:
Screenshot 2024-09-30 at 1 39 05 PM

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@mau11 mau11 changed the base branch from main to stage-main-14.1.1 September 30, 2024 17:41
Copy link
Collaborator

@engelhartrueben engelhartrueben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@mau11 mau11 merged commit 93d1041 into stage-main-14.1.1 Oct 1, 2024
17 checks passed
@mau11 mau11 mentioned this pull request Oct 1, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants