-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Scrubber #2471
Fix Scrubber #2471
Conversation
if (lookupName) { | ||
// caller-name is more expensive | ||
types.push("caller-name"); | ||
types.fields = ("line_type_intelligence,caller-name"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be an array instead of parentheses?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oddly enough, no: https://www.twilio.com/docs/lookup/v2-api#code-lookup-with-data-packages
Twilio wants types.fields
as a comma separated string. That parentheses is awkward though
@@ -306,6 +306,7 @@ export async function nextBatchJobLookups({ | |||
lastCount, | |||
steps | |||
); | |||
console.log("scrub-bad-mobilenums error: ", err); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
log.error
@mau11 the changes we talked about are in. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Fixes # (issue)
Scrubbing numbers with Twilio
Description
Upgraded Twilio Lookup to V2. Twilio Documentation
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change, and any blockers that make your change a WIP
Checklist: