Add instructions for local postgres #2442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add additional documentation on how to set up Postgres if using a local installation and not Docker.
docs/HOWTO_USE_POSTGRESQL.md
Outdated
| * Grant permissions to the new Spoke user: | ||
| * `psql -d spokedev -c "GRANT ALL PRIVILEGES ON DATABASE spokedev TO spoke;"` | ||
| * `psql -d spokedev -c "GRANT ALL PRIVILEGES ON schema public TO spoke;"` | ||
| * Also run the commands from `./dev-tools/create-test-database`: |
There was a problem hiding this comment.
This tool won't work for local pg because its set up for docker.
There was a problem hiding this comment.
Right, I'm not saying to run the script directly but to manually run the commands to create a test database instead.
There was a problem hiding this comment.
Ahh I see. I would instead have you place those instructions directly in the document (minus the docker stuff). I can see new devs getting confused like I did.
There was a problem hiding this comment.
I updated the explanation, hopefully this is more clear!
We don't actually want to run the script, which is built for Docker environments - we just want to run the SQL commands from that script.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add additional documentation on how to set up Postgres if using a local installation and not Docker. I tried setting up locally with a preexisting Postgres installation and found I needed to make the listed changes.
Checklist: