Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for campaign sort bug #2384

Merged
merged 4 commits into from
Jul 24, 2024

Conversation

engelhartrueben
Copy link
Collaborator

Fixes # (issue)

Fix bug where when sorting campaign list, "white screen of death" would occur caused by attempting to write to a read only object.

Description

set campaign data to state, allowing for manipulation
set the default sort to descending ID's

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@engelhartrueben engelhartrueben changed the title Re/campaign sort bug fix for campaign sort bug Jul 23, 2024
@engelhartrueben engelhartrueben merged commit 7ada060 into stage-patch-main-14.0.1 Jul 24, 2024
17 checks passed
@engelhartrueben engelhartrueben deleted the re/campaign-sort-bug branch July 24, 2024 13:45
@engelhartrueben engelhartrueben mentioned this pull request Jul 24, 2024
7 tasks
engelhartrueben added a commit that referenced this pull request Jul 24, 2024
* bug/2382: currentInteractionStep variable needs to continue w/in block instead of new const

* Dependabot Config File (#2379)

* init dependabot.yml

* typo

* fix for campaign sort bug (#2384)

* fix bug where the CampaignTable would white screen of death after trying to sort

* set initial sort to ID_DESC

* remove sorting on archive column

* call this.state.campaigns directly wherever possible. Object destructured pageInfo immidiately

* add 14.0.1 release notes

* 14.0 >> 14.0.1

* link pr's

* fix typo

---------

Co-authored-by: Schuyler Duveen <[email protected]>
Co-authored-by: Maureen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants