Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback config #1963

Merged
merged 2 commits into from
Apr 13, 2021
Merged

Feedback config #1963

merged 2 commits into from
Apr 13, 2021

Conversation

codygordon
Copy link
Collaborator

Description

  1. The texter feedback custom config issue and skills items weren't actually being used, fixed that.
  2. We want the org-level custom feedback config to be used when the campaign has feedback turned on but no custom config entered.

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@codygordon codygordon added the C-bug Type: Bug label Mar 29, 2021
schuyler1d
schuyler1d approved these changes Mar 30, 2021
View reviewed changes
Copy link
Collaborator

@schuyler1d schuyler1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@schuyler1d schuyler1d added the S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc label Mar 30, 2021
@schuyler1d schuyler1d mentioned this pull request Mar 30, 2021
Merged
@schuyler1d schuyler1d merged commit 1854cf8 into StateVoicesNational:main Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schuyler1d schuyler1d schuyler1d approved these changes

Assignees
No one assigned
Labels
C-bug Type: Bug S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codygordon @schuyler1d