Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Message review table overflow visible for long tags & truncate long tag text #1960

Merged
merged 1 commit into from
Apr 13, 2021

Conversation

codygordon
Copy link
Collaborator

@codygordon codygordon commented Mar 23, 2021

Fixes https://github.com/MoveOnOrg/Spoke/issues/1894

Description

@navinsivakumar: In the Message Review incoming message list, allow long TagChips to overflow their table cells and allow horizontal scrolling of the table. This ensures that users can both see the entire tag text and access the delete button when using any combination of small enough screen, long enough tag text, and large enough text size such that the TagChip does not fit entirely inside its table cell.

@codygordon: I also set a max-width for tag text so they can't be infinitely long (we should probably have a character limit on tag names anyhow).

Also darkened the tag text to make them pop a bit more.

Resulting in:

Screen Shot 2021-03-23 at 8 31 26 AM

@Frydafly Frydafly added A-Texter UI/UX Area: Texter interface and experience S-waiting on review Status: Awaiting review from the assignee but also interested parties labels Mar 27, 2021
Copy link
Collaborator

@schuyler1d schuyler1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@schuyler1d schuyler1d added S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc and removed S-waiting on review Status: Awaiting review from the assignee but also interested parties labels Mar 30, 2021
@schuyler1d schuyler1d merged commit bf7a5f7 into StateVoicesNational:main Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Texter UI/UX Area: Texter interface and experience S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: In the Message Review table of messages, long tags get truncated so you cannot click the "X" button
3 participants