Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix people search when text filter is ANY #1937

Merged
merged 3 commits into from
Apr 13, 2021
Merged

fix people search when text filter is ANY #1937

merged 3 commits into from
Apr 13, 2021

Conversation

schuyler1d
Copy link
Collaborator

Description

When there's a people search text filter and setting is ANY it interprets the where clause with ORs globally instead of narrowly in the first/last/email fields. This adds parens

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • [na] If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • [na] I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • [na] My PR is labeled [WIP] if it is in progress

@schuyler1d schuyler1d added the S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc label Mar 4, 2021
@ibrand ibrand temporarily deployed to spoke-review-fix-people-6jx5tn March 4, 2021 02:32 Inactive
@ibrand ibrand temporarily deployed to spoke-review-fix-people-6jx5tn March 4, 2021 21:58 Inactive
@ibrand ibrand temporarily deployed to spoke-review-fix-people-6jx5tn March 5, 2021 14:28 Inactive
@schuyler1d schuyler1d merged commit b987bd0 into main Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants