Return informative errors from GraphQL endpoint #1932
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I noticed while working on a web component that all errors coming back from the graphql endpoint were empty objects. When an error was thrown in a query or mutation, this code would be called with
graphQLErrors
equal to an array consisting of an empty object --[{}]
. The error thrown in the client would be simplyerror Error: GraphQL error: undefined
which doesn't let us give the user any useful information.This PR has two commits. The first commit could be a solution on its own depending on what we think should be disclosed in the web app.
The first commit improves the situation a little, resulting in an error with this message:
error Error: GraphQL error: Internal server error
.The second commit returns this (as an example)
error Error: GraphQL error: Invalid Twilio credentials
.Also, I believe this is dead code now.
Checklist: