No yellow badges

[stefanhayden]

Fixes #1874

Description

Volunteer texters see the yellow badges on buckets of handled conversations and want to get rid of the badges so they opt people out to “clear” those conversations leading to lots of admin clean-up.

This PR removes those yellow badge icons and inlines the number. This make it so folks don't think they are a number that needs to be addressed.

Checklist:

• I have manually tested my changes on desktop and mobile
• The test suite passes locally with my changes
• If my change is a UI change, I have attached a screenshot to the description section of this pull request
• My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
• I have made any necessary changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• My PR is labeled [WIP] if it is in progress

[stefanhayden]

Question!

the renderBadgedButton function seems to let the counts be passed in as undefined. Is that on purpose? It would seem that if we want to hide buttons on 0 then we would also want to hide them on undefined? I also ask this because in the spec file we seem to not pass some counts causing some to be undefined and then the test seem to check if those buttons that are supposed to be hidden if 0 count actually exist?

I would want to / expect 0 and undefined to be treated basically the same way unless we are doing it this way on purpose.

[schuyler1d]

I'm not sure about the undefined use case, so I'm tempted to leave it be as-is. I know I was doing some work a while ago about sometimes not getting counts and just getting 'some exist vs. none exist' but I don't think that's what the undefined thing is about.