Change -1 error message to not suggest an automatic retry #1898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 17, 2020 12:13
schuyler1d
approved these changes
Jan 11, 2021
schuyler1d
added
S-post-election 2020 stable
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Automatic retries are not the default behavior on a new Spoke build, so the error message when you get a -1 shouldn't suggest a retry is coming. I did not change the messages for -2 to -5, since to reach those cases your build must be employing some manner of retry logic.
See https://progcode.slack.com/archives/C717R1DMZ/p1606154352333200 for slightly more discussion.