Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow vertical scrolling of tags sidebox independent from message list #1897

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

navinsivakumar
Copy link
Contributor

Fixes #1896

Description

Add overflow-y: scroll to CSS for sectionSideBox in AssignmentTexterContactControls. This allows the tag sidebox to scroll independently from the message list in the texter conversation view, so that the texter can scroll to the bottom of long lists of tags without causing the conversation to disappear off screen. See screenshot below of a tag sidebox scrolled vertically without changing moving the conversation message list (and compare to screenshot in #1896).

I also verified that the behavior of the popup sidebox (used when the viewport is narrow) is unchanged.

Screen Shot 2020-11-28 at 7 06 22 PM

Checklist:

  • I have manually tested my changes on desktop and mobile
    • On mobile I tested using device emulation in Chrome. My physical mobile device has a small enough screen that the conversation view is completely unusable in landscape mode (which is the only way to get the viewport wide enough for the sidebox to appear on the side).
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
    • If there is a way to test a purely UI/style change, let me know and I will add something.
  • My PR is labeled [WIP] if it is in progress
    • n/a

Copy link
Collaborator

@schuyler1d schuyler1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@schuyler1d schuyler1d added S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc S-post-election 2020 stable Conservative change with only bugfixes or minor changes in stage-main-postelection2020-stable labels Jan 11, 2021
@schuyler1d schuyler1d mentioned this pull request Jan 11, 2021
@schuyler1d schuyler1d merged commit e94a854 into StateVoicesNational:main Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-post-election 2020 stable Conservative change with only bugfixes or minor changes in stage-main-postelection2020-stable S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Texter sidebox should scroll independently from the message list
2 participants