Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add phone inventory config var to the code while keeping the experime… #1875

Closed
wants to merge 1 commit into from

Conversation

ibrand
Copy link
Collaborator

@ibrand ibrand commented Oct 19, 2020

…ntal var

Description

Every few weeks someone applies the PHONE_INVENTORY env var as they setup a new instance cause that's what our docs say to do and then there's this one area of the code that doesn't yet have the phone inventory conditional and their phone inventory screen doesn't register their numbers even as they buy them from Twilio. This should fix that.

Admittedly I don't have a good dev env set up for testing this. I can definitely set that up. The tests do all pass with this in though.

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer

@ibrand ibrand temporarily deployed to spoke-review-phone-inve-jvhrt0 October 19, 2020 16:33 Inactive
Copy link
Collaborator

@schuyler1d schuyler1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@schuyler1d
Copy link
Collaborator

I think we could even merge this now, if you think that makes sense.

@crayolakat
Copy link
Collaborator

crayolakat commented Apr 11, 2022

Closing this since the issue has already been addressed and merged into main by the following:

@crayolakat crayolakat closed this Apr 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants