Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to reorder survey questions via buttons "bump", "top" and "bottom" WIP #1855

Merged

Conversation

oburbank
Copy link
Contributor

Fixes # (issue)

https://github.com/MoveOnOrg/Spoke/issues/1564

Description

I added 3 buttons that allow users to reorder survey questions.

  • Bump: lifts the question above its first sibling that precedes it.
  • Top: lifts the question to be the first of its siblings.
  • Bottom: lowers the question to be the last of its siblings.

This is a work in progress. WIP. Styling isn't perfect, and no drag and drop for now. Will need to test a bit more.

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

Copy link
Collaborator

@schuyler1d schuyler1d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@schuyler1d schuyler1d mentioned this pull request Jan 15, 2021
@schuyler1d schuyler1d merged commit dd120c3 into StateVoicesNational:main Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants