Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop needMessageCount input from zeroing-out #1805

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

oburbank
Copy link
Contributor

@oburbank oburbank commented Sep 3, 2020

Fixes # (issue)

https://github.com/MoveOnOrg/Spoke/issues/1587

Description

I added React Formal's mapToValue method to override the value retrieved by name, which can become stale as new texters are added.

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@oburbank oburbank changed the title My fixes Stop needMessageCount input from zeroing-out Sep 3, 2020
@schuyler1d schuyler1d mentioned this pull request Dec 3, 2020
@schuyler1d
Copy link
Collaborator

Thank you! Needed to tweak this a little bit to:
mapToValue={m => m.texters.find(t => t.id === texter.id).assignment.needsMessageCount} to make the text input update properly.

@schuyler1d schuyler1d merged commit 7424642 into StateVoicesNational:main Jan 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants