Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic assignment batches #1702

Merged
merged 10 commits into from
Aug 12, 2020
Merged

Dynamic assignment batches #1702

merged 10 commits into from
Aug 12, 2020

Conversation

schuyler1d
Copy link
Collaborator

@schuyler1d schuyler1d commented Jul 30, 2020

Fixes https://github.com/MoveOnOrg/Spoke/issues/1533

Description

Changes Dynamic Assignment

TODO:

  • extensible changes to AssignmentSummary (on the todos page) from texter-sideboxes
  • extensible changes to assignment.hasUnassignedContactsForTexter so a choice for when/who can request another batch (e.g. vetted texters, or after replies are finshed, etc)
  • change/add tests

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • [NO] My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@schuyler1d schuyler1d added S-work in progress (WIP) Status: PR label for work that is not yet ready to be reviewed S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc labels Jul 30, 2020
@schuyler1d schuyler1d requested review from hiemanshu and matteosb July 30, 2020 18:41
@ibrand ibrand temporarily deployed to spoke-review-dynamicass-4x54uw July 30, 2020 18:42 Inactive
@ibrand ibrand temporarily deployed to spoke-review-dynamicass-4x54uw July 30, 2020 19:26 Inactive
@hiemanshu
Copy link
Collaborator

@schuyler1d One change that was made after we open sourced the patches was to change the findNewCampaignContact mutation to only reassign when message_status is needsMessage, otherwise it would reassign replies, and other side effects.

Here: https://github.com/MoveOnOrg/Spoke/blob/main/src/server/api/mutations/findNewCampaignContact.js#L70

@ibrand ibrand temporarily deployed to spoke-review-dynamicass-4x54uw July 30, 2020 21:54 Inactive
@ibrand ibrand temporarily deployed to spoke-review-dynamicass-4x54uw July 31, 2020 00:42 Inactive
@ibrand ibrand temporarily deployed to spoke-review-dynamicass-4x54uw July 31, 2020 03:49 Inactive
@schuyler1d schuyler1d mentioned this pull request Jul 31, 2020
@schuyler1d schuyler1d removed the S-work in progress (WIP) Status: PR label for work that is not yet ready to be reviewed label Jul 31, 2020
@schuyler1d schuyler1d changed the title WIP: Dynamic assignment batches Dynamic assignment batches Jul 31, 2020
@schuyler1d schuyler1d merged commit d3b963e into main Aug 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: Request/Release-style dynamic assignment + Texter Sidebox extensibility
3 participants