Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AssignmentTexter refactor #1534

Merged
merged 14 commits into from
May 6, 2020
Merged

AssignmentTexter refactor #1534

merged 14 commits into from
May 6, 2020

Conversation

schuyler1d
Copy link
Collaborator

Part of https://github.com/MoveOnOrg/Spoke/issues/1533

Description

This moves a BUNCH of files around -- every component that is only used for the texter's contact screen is moved into components/AssignmentTexter/

I think the main question in this PR is how do we want to organize components/containers further?
I think @lperson started doing work that grouped these things. While this still groups things in containers/components division is it better to group even further and lose the distinction between container and component (which I don't think we're perfect on) or group them all together (in this case it would move the directory into containers/ and then everything would be under, e.g. TexterTodo/

Do folks have bikeshed thoughts on organization here?

Checklist:

  • I have manually tested my changes on desktop and mobile
  • The test suite passes locally with my changes
  • [na] If my change is a UI change, I have attached a screenshot to the description section of this pull request
  • My change is 300 lines of code or less, or has a documented reason in the description why it’s longer
  • [na] I have made any necessary changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • My PR is labeled [WIP] if it is in progress

@schuyler1d schuyler1d added the S-work in progress (WIP) Status: PR label for work that is not yet ready to be reviewed label May 5, 2020
@schuyler1d schuyler1d added the S-on deck Status (ADMINS ONLY): PR label for those that will be added to the next stage label May 5, 2020
@schuyler1d schuyler1d added S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc and removed S-on deck Status (ADMINS ONLY): PR label for those that will be added to the next stage labels May 6, 2020
Copy link
Collaborator

@matteosb matteosb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, I'm all for this grouping. IMO the containers/ components distinction isn't particularly useful right now. I'd prefer to see components used only for those components that are designed to be re-usable and ideally stateless, while keeping all "private" components grouped with containers.

@schuyler1d schuyler1d merged commit 37549c9 into stage-main May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-ready for stage-main (qa) Status (ADMINS ONLY): PR label for those ready to be added for stage: Approved, tests, etc S-work in progress (WIP) Status: PR label for work that is not yet ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants