-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AssignmentTexter refactor #1534
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, I'm all for this grouping. IMO the containers
/ components
distinction isn't particularly useful right now. I'd prefer to see components
used only for those components that are designed to be re-usable and ideally stateless, while keeping all "private" components grouped with containers.
Part of https://github.com/MoveOnOrg/Spoke/issues/1533
Description
This moves a BUNCH of files around -- every component that is only used for the texter's contact screen is moved into components/AssignmentTexter/
I think the main question in this PR is how do we want to organize components/containers further?
I think @lperson started doing work that grouped these things. While this still groups things in containers/components division is it better to group even further and lose the distinction between container and component (which I don't think we're perfect on) or group them all together (in this case it would move the directory into containers/ and then everything would be under, e.g. TexterTodo/
Do folks have bikeshed thoughts on organization here?
Checklist: