forked from kubeflow/kubeflow
-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix vm service account config, doc update (kubeflow#931)
* fix vm service account config, doc update * rebase, and handle feedback
- Loading branch information
1 parent
dee2528
commit 38a3813
Showing
3 changed files
with
7 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -66,16 +66,16 @@ resources: | |
# - group:[email protected] | ||
# Path for the bootstrapper image. | ||
bootstrapperImage: gcr.io/kubeflow-images-public/bootstrapper:latest | ||
# This is the name of the GCP static ip address to reserve for your domain. | ||
# This must be different for each Kubeflow deployment in your project. | ||
# This is the name of the GCP static ip address reserved for your domain. | ||
# Each Kubeflow deployment in your project should use one unique ipName among all configs. | ||
ipName: kubeflow-ip | ||
# Provide the config for the bootstrapper. This should be a string | ||
# containing the YAML spec for the bootstrapper. | ||
# | ||
# You should set the following parameters in bootstrapperConfig. | ||
# acmeEmail - Set this to your email address; this is used with lets-encrypt. | ||
# ipName - This is the name of the static ip address reserved in GCP to be used with ingress. | ||
# keep this in sync with the value of property ipName | ||
# Keep the value of ipName in sync with the value in the bootstrapper config section below. | ||
# hostName - This is the fully qualified domain name to serve Kubeflow at. | ||
# 1. To use the GCP provided domain endpoints.<Project>.cloud.goog set this to | ||
# <name>.endpoints.<Project>.cloud.goog | ||
|
@@ -108,7 +108,7 @@ resources: | |
value: [email protected] | ||
- component: iap-ingress | ||
name: ipName | ||
# TODO: Keep this in sync with the value of property ipName | ||
# TODO: make sure value of ipName is the same as property <ipName>. | ||
value: ipName | ||
- component: iap-ingress | ||
name: hostname | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters