Implement temp client banning on failed requests #38
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #35
Problem statement:
Prometheus needs quick exporter page loads for its scrape intervals, and attempting to load these metrics from a Proxmox server that is down can have the consequence of drastically slowing down page loads while waiting for the failed requests to that client to time out.
Proposed solution:
When a request fails against a particular client in the clients list, that client should be temporarily banned. A separate goroutine should run to inspect current bans, make a request against the Proxmox server, see if it succeeds, and unbans the client if the request succeeded. All API requests made for the exporter should check if the client they picked out at random was banned, and skip it if so.
Potential problems: