Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] fix error parameters when replaying drop temp table #55056

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[BugFix] fix error parameters when replaying drop temp table #55056

merged 1 commit into from
Jan 23, 2025

Conversation

silverbullet233
Copy link
Contributor

@silverbullet233 silverbullet233 commented Jan 14, 2025 •
edited
Loading

Why I'm doing:

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@silverbullet233 silverbullet233 force-pushed the fix-temp-table branch 2 times, most recently from eb10c51 to 3084fb3 Compare January 17, 2025 01:40
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
6 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 1 / 1 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/server/LocalMetastore.java 1 1 100.00% []

@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@silverbullet233 silverbullet233 enabled auto-merge (squash) January 17, 2025 08:27
@silverbullet233 silverbullet233 merged commit a3566ca into StarRocks:main Jan 23, 2025
46 checks passed
@silverbullet233 silverbullet233 deleted the fix-temp-table branch January 23, 2025 02:15
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 23, 2025
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jan 23, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 23, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 23, 2025
@silverbullet233 @mergify
[BugFix] fix error parameters when replaying drop temp table (#55056)
0a537e8 
Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit a3566ca)
mergify bot pushed a commit that referenced this pull request Jan 23, 2025
@silverbullet233 @mergify
[BugFix] fix error parameters when replaying drop temp table (#55056)
1a2b125 
Signed-off-by: silverbullet233 <[email protected]>
(cherry picked from commit a3566ca)
This was referenced Jan 23, 2025
Merged
Merged
wanpengfei-git pushed a commit that referenced this pull request Jan 23, 2025
@mergify @silverbullet233
[BugFix] fix error parameters when replaying drop temp table (backport …
effb3a5 
…#55056) (#55351)

Signed-off-by: silverbullet233 <[email protected]>
Co-authored-by: eyes_on_me <[email protected]>
Co-authored-by: silverbullet233 <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Feb 17, 2025
@mergify @silverbullet233
[BugFix] fix error parameters when replaying drop temp table (backport …
4237989 
…#55056) (#55350)

Signed-off-by: silverbullet233 <[email protected]>
Co-authored-by: eyes_on_me <[email protected]>
Co-authored-by: silverbullet233 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Seaven Seaven Seaven approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

Assignees

@silverbullet233 silverbullet233

Labels
3.3-merged 3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silverbullet233 @Seaven @gengjun-git