Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Only enable query context cache when there are more than one related mvs #54627

Merged
merged 2 commits into from
Jan 3, 2025
Merged

[BugFix] Only enable query context cache when there are more than one related mvs #54627

merged 2 commits into from
Jan 3, 2025

Conversation

LiShuMing
Copy link
Contributor

@LiShuMing LiShuMing commented Jan 3, 2025 •
edited
Loading

Why I'm doing:

  • mvQueryContextCache is enabled when related mv is more than 1 since the cache is used to cache query predicates rewrite for different mvs.

What I'm doing:

Fixes #issue

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.4
    • 3.3
    • 3.2
    • 3.1
    • 3.0

@LiShuMing LiShuMing requested review from a team as code owners January 3, 2025 01:56
@LiShuMing
fix bugs
8ef22fb 
Signed-off-by: shuming.li <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jan 3, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

[Java-Extensions Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

[FE Incremental Coverage Report]

✅ pass : 39 / 39 (100.00%)

file detail

path covered_line new_line coverage not_covered_line_detail
🔵 com/starrocks/sql/optimizer/MvRewritePreprocessor.java 11 11 100.00% []
🔵 com/starrocks/sql/optimizer/QueryMaterializationContext.java 26 26 100.00% []
🔵 com/starrocks/connector/ConnectorPartitionTraits.java 2 2 100.00% []

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@stephen-shelby stephen-shelby merged commit cadb57f into StarRocks:main Jan 3, 2025
64 checks passed
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

@Mergifyio backport branch-3.4

@github-actions github-actions bot removed the 3.4 label Jan 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 3, 2025

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label Jan 3, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025 •
edited
Loading

backport branch-3.4

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025 •
edited
Loading

backport branch-3.3

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jan 3, 2025
@LiShuMing @mergify
[BugFix] Only enable query context cache when there are more than one…
36a85ad 
… related mvs (#54627)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit cadb57f)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessorOlapPart2Test.java
@mergify mergify bot mentioned this pull request Jan 3, 2025
Merged
18 tasks
mergify bot pushed a commit that referenced this pull request Jan 3, 2025
@LiShuMing @mergify
[BugFix] Only enable query context cache when there are more than one…
c3876ba 
… related mvs (#54627)

Signed-off-by: shuming.li <[email protected]>
(cherry picked from commit cadb57f)

# Conflicts:
#	fe/fe-core/src/test/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessorIcebergTest.java
#	fe/fe-core/src/test/java/com/starrocks/scheduler/PartitionBasedMvRefreshProcessorOlapPart2Test.java
@mergify mergify bot mentioned this pull request Jan 3, 2025
Merged
18 tasks
maggie-zhu pushed a commit to maggie-zhu/starrocks that referenced this pull request Jan 6, 2025
@LiShuMing
[BugFix] Only enable query context cache when there are more than one…
e772898 
… related mvs (StarRocks#54627)

Signed-off-by: shuming.li <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jan 7, 2025
@mergify @LiShuMing
[BugFix] Only enable query context cache when there are more than one…
60609e3 
… related mvs (backport #54627) (#54667)

Signed-off-by: shuming.li <[email protected]>
Co-authored-by: shuming.li <[email protected]>
wanpengfei-git pushed a commit that referenced this pull request Jan 7, 2025
@mergify @LiShuMing
[BugFix] Only enable query context cache when there are more than one…
0f762c3 
… related mvs (backport #54627) (#54668)

Signed-off-by: shuming.li <[email protected]>
Co-authored-by: shuming.li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephen-shelby stephen-shelby stephen-shelby approved these changes

@Seaven Seaven Seaven approved these changes

@satanson satanson satanson approved these changes

Assignees

@LiShuMing LiShuMing

Labels
3.3-merged 3.4-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@LiShuMing @satanson @Seaven @stephen-shelby